fix: allow splicing into shadow block stacks #6939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
LGTM!
Two things I noticed that don't need to be fixed:
- Both conditionals for next statements have extra checks for shadows. Theoretically we could just return true for shadows?
- For the tests, you should be able to use JSON now, since we're serializing the disabled interaction properties in core.
|
I am hesitant to refactor the logic now since this one has now had much additional scrutiny, but something we could follow up on after a patch release. |
BeksOmega
pushed a commit
that referenced
this pull request
Mar 30, 2023
* fix: allow splicing into shadow block stacks * chore: format (cherry picked from commit 69afe5b)
maribethb
added a commit
to maribethb/blockly
that referenced
this pull request
Apr 13, 2023
* fix: allow splicing into shadow block stacks * chore: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6938
Proposed Changes
Fixes a bug in #6800 where you couldn't splice into shadow block stacks. Adds a test case for this behavior.
Behavior Before Change
Couldn't replace a shadow block in a statement input.
Behavior After Change
Can replace shadow blocks in a statement input.
Reason for Changes
Test Coverage
Adds test case for shadow block.
Documentation
Additional Information