fix: connection locations not updating #6921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Aaron discovered an issue with the ternary block during testing, where blocks couldn't be connected to it. Turns out that some connection locations weren't being added to the db due to the
movedcheck. I'm not sure why this is occuring, so I'm just removing it for now. This does give us a performance hit of ~20ms when moving spaghetti blocks around. But it's still ~5x faster than on master so nbd.Proposed Changes
Fixes regression where connections weren't being added to the db.
Reason for Changes
Regressions are sad.
Test Coverage
Manual testing.
Documentation
N/A
Additional Information
Going to create an issue for reverting this now that I've created this PR.
This is release blocking.