-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove forced rerender from mutator #6918
Conversation
Fixes #6953 correct? |
Editted PR description! |
Sorry, what should I do to have the solution to #6953 ? |
I applaud this instinct, but it looks like in this particular case you should have had more faith in your coding! |
The easiest thing is to wait for the next release of Blockly. If this (annoying but largely cosmetic) bug can't wait, you can build Blockly yourself from the |
(cherry picked from commit d897cdc)
The basics
npm run format
andnpm run lint
The details
Resolves
Fixes #3511
Fixes #6953
Work on #4288
Proposed Changes
Removes the batch rendering from the mutator logic - since we now have actual batch rendering that doesn't rely on mangling the
rendered
property!Reason for Changes
Code simplification.
Test Coverage
Manually tested that #4175 and #3458 do not reproduce.
Tested that mutating continues to work.
Documentation
N/A
Additional Information
While I do trust this code, I don't trust it enough to put it into the imminently approaching release. So I'm going to put this up as a draft.