fix: toString performance #6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Mar 15, 2023
|
|
||
| let node = ASTNode.createBlockNode(this); | ||
| const rootNode = node; | ||
| let prev = ''; |
There was a problem hiding this comment.
Can you add the comment too?
// Join the text array, removing the spaces around added parentheses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #4229
Proposed Changes
Increases peformance of
toString50x. Used to take ~50ms, now takes <1ms.Reason for Changes
Speeeeed.
Test Coverage
Just manual testing.
Documentation
N/A
Additional Information
N/A