Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty procedure arrays in serialization #6872

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes N/A

Proposed Changes

Makes it so that ifthere are no procedure models in the workspace the procedure serializer returns null.

Behavior Before Change

Workspaces without procedure models would be serialized as:

{
  'procedures': [],
}

Behavior After Change

Workspaces without procedure models are serialized as:

{ }

Reason for Changes

The tiniest amount of space saving.

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner March 1, 2023 19:27
@BeksOmega BeksOmega requested a review from cpcallen March 1, 2023 19:27
@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 1, 2023
@BeksOmega BeksOmega merged commit 67dd6df into google:develop Mar 13, 2023
@BeksOmega BeksOmega deleted the fix/proc-serialization branch May 14, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants