Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove more uses of AnyDuringMigration #6863

Merged
merged 10 commits into from
Feb 28, 2023
Merged

refactor: Remove more uses of AnyDuringMigration #6863

merged 10 commits into from
Feb 28, 2023

Conversation

gonfunko
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Part of #5857

Proposed Changes

Replaces various uses of AnyDuringMigration with accurate type information.

@gonfunko gonfunko added the breaking change Used to mark a PR or issue that changes our public APIs. label Feb 24, 2023
@gonfunko gonfunko requested a review from a team as a code owner February 24, 2023 20:57
@gonfunko gonfunko changed the title Anys refactor: Remove more uses of AnyDuringMigration Feb 24, 2023
@github-actions github-actions bot added PR: refactor and removed breaking change Used to mark a PR or issue that changes our public APIs. labels Feb 24, 2023
BeksOmega
BeksOmega requested changes Feb 24, 2023
View reviewed changes
core/block_svg.ts Show resolved Hide resolved
core/names.ts Outdated Show resolved Hide resolved
core/xml.ts Outdated Show resolved Hide resolved
core/xml.ts Show resolved Hide resolved
tests/mocha/workspace_svg_test.js Show resolved Hide resolved
@gonfunko gonfunko added the breaking change Used to mark a PR or issue that changes our public APIs. label Feb 27, 2023
BeksOmega
BeksOmega approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last fix! Otherwise LGTM =)

@gonfunko gonfunko removed the breaking change Used to mark a PR or issue that changes our public APIs. label Feb 28, 2023
@gonfunko gonfunko merged commit 8a44dff into google:develop Feb 28, 2023
@gonfunko gonfunko deleted the anys branch February 28, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
PR: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonfunko @BeksOmega