feat: updated flyout button to set border radius via static variable #6838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeilFraser
approved these changes
Feb 10, 2023
|
After the variable is extracted, it still cannot be modified from the outside, and the set method is not provided. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
In response to https://groups.google.com/g/blockly/c/sMG41uE-WG0, this enables setting the border radius via overwriting the newly added static variable.
Proposed Changes
Add static variable for the button's border radius.
Behavior Before Change
No static variable for Flyout Button's border radius.
Behavior After Change
Added static variable for Flyout Button's border radius.