fix: Don't clober event group when renaming vars #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also audit all existing event group commands and tweak a few of them where I think there's a potential issue.
gonfunko
reviewed
Feb 8, 2023
core/contextmenu_items.ts
Outdated
| @@ -279,7 +278,8 @@ export function registerDeleteAll() { | |||
| } | |||
| scope.workspace.cancelCurrentGesture(); | |||
| const deletableBlocks = getDeletableBlocks_(scope.workspace); | |||
| const eventGroup = idGenerator.genUid(); | |||
| eventUtils.setGroup(true); | |||
There was a problem hiding this comment.
If the user chooses cancel on the dialog, deleteNext_ is never run and grouping is never turned off. deleteNext_ was already calling setGroup() with the passed-in ID - why is this change necessary?
There was a problem hiding this comment.
This changes eliminates the dependency on idGenerator. It also means that in Blockly there would be only one place which sets eventGroup -- so if we change the group format in the future, we won't need to change it in two places.
There was a problem hiding this comment.
Got it, that makes sense; I think the issue about grouping never being turned back off if the user chooses Cancel on the confirmation dialog still stands though.
|
Does this also address #1534? |
gonfunko
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also audit all existing event group commands and tweak a few of them where I think there's a potential issue.
See https://groups.google.com/g/blockly/c/dKizQbKb8vo