Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fire deletion events when clearing variables. #6827

Merged
merged 3 commits into from
Feb 7, 2023
Merged

fix: Fire deletion events when clearing variables. #6827

merged 3 commits into from
Feb 7, 2023

Conversation

NeilFraser
Copy link
Contributor

@NeilFraser NeilFraser requested a review from a team as a code owner February 7, 2023 11:10
@github-actions github-actions bot added the PR: fix Fixes a bug label Feb 7, 2023
koenvanwijk
koenvanwijk reviewed Feb 7, 2023
View reviewed changes
Copy link
Contributor

@koenvanwijk koenvanwijk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the console.log still needs to be removed. Sorry you fixed in in a later commit. Please ignore.

@NeilFraser NeilFraser merged commit 9021736 into develop Feb 7, 2023
@NeilFraser NeilFraser deleted the fraser-variableEvent branch February 7, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koenvanwijk koenvanwijk koenvanwijk left review comments

@cpcallen cpcallen cpcallen approved these changes

Assignees

@cpcallen cpcallen

Labels
PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeilFraser @cpcallen @koenvanwijk