Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use the field registry to instantiate fields in block definitions. #6811

Merged
merged 3 commits into from
Feb 7, 2023
Merged

refactor: Use the field registry to instantiate fields in block definitions. #6811

merged 3 commits into from
Feb 7, 2023

Conversation

gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Feb 1, 2023

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#6611

Proposed Changes

Updates the standard block definitions to use the field registry to instantiate fields, rather than instantiating the field classes directly.

@gonfunko gonfunko requested a review from a team as a code owner February 1, 2023 23:53
@gonfunko gonfunko changed the title Json fields refactor: Use the field registry to instantiate fields in block definitions. Feb 1, 2023
@gonfunko gonfunko merged commit cf8be1f into google:develop Feb 7, 2023
@gonfunko gonfunko deleted the json-fields branch February 7, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeilFraser NeilFraser NeilFraser approved these changes

Assignees

@NeilFraser NeilFraser

Labels
PR: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonfunko @NeilFraser