feat: Add support for centering on a block itself vs its stack. #6810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Feb 1, 2023
There was a problem hiding this comment.
LGTM!
Was looking to see if we had any relevant tests for this code, and it seems our only test is actually broken (it calls zoomToFit instead of centerOnBlock):
blockly/tests/mocha/workspace_svg_test.js
Line 208 in 7cbdf0d
This doesn't actually test the code you wrote :P But would you mind cleaning it up rq? If not that's cool, I can grab it!
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#5432
Proposed Changes
Adds an optional argument to centerOnBlock() that, if set to true, will center the workspace on the block itself, rather than the default behavior of centering on that block's stack.