Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change assertFieldValue in test helpers to use deepEqual #6739

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

Samridhi-98
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #6180

Proposed Changes

Changes Done

  • Updated tests/mocha/test_helpers/fields.js

@Samridhi-98 Samridhi-98 requested a review from a team as a code owner January 7, 2023 09:08
@Samridhi-98 Samridhi-98 requested a review from BeksOmega January 7, 2023 09:08
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 7, 2023
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Samridhi-98 :D Looks great!

@BeksOmega BeksOmega merged commit 5dbcaeb into google:develop Jan 9, 2023
@Samridhi-98 Samridhi-98 deleted the fix-test branch January 10, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change assertFieldValue in test helpers to use deepEqual
2 participants