fix: set default field to any and fix validator function return type #6690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
Although the default Field type
T
should eventually beunknown
, set it toany
so it does not break users with subclasses extending fromField
in the meantime.Proposed Changes
core/field.ts
-FieldValidator
to provide the correct return type.core/field.ts
-T = unknown
toT = any
Behavior Before Change
TypeScript users with classes extending from
Field
would have to fill in a type forField
or their code will break.Behavior After Change
TypeScript users can now extend from
Field
without providing the value type.Reason for Changes
This is for introducing the Field type information in multiple stages.
Test Coverage
N/A
Documentation
N/A
Additional Information
Nope!