fix: Fix the compiler test, and check if it worked. #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsc generates JavaScript which is incompatible with the Closure Compiler's advanced optimizations.
The Mocha and generator tests can both be run either manually or via our webdriver. In all cases they run in a browser. These two 'run_X_in_browser.js' files only apply to webdriver, thus they are confusingly named. Also delete completely unused (and broken) `run_all_tests.sh`
Still not at 100%. Complains about require/module/process/__dirname not being defined in multiple places.
'Block' means something very different in Blockly.
cpcallen
requested changes
Nov 25, 2022
cpcallen
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeScript compiler generates some code relating to enums that's not compatible with the Closure Compiler's advanced optimizations. This PR adds a lightweight converter that fixes these enums and restores the functionality of this test.
Furthermore, this PR adds a webdriver-based check to verify that if the compiler finished, the result loads successfully.
Plus some refactoring on other tests.