Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add firing of procedure events. #6604

Merged
merged 12 commits into from
Nov 11, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

#6516

Proposed Changes

Adds firing procedure events to the procedure data models.

Reason for Changes

Firing events appropriately is good :D

Test Coverage

Enabled all events from #6593

Documentation

N/A

Additional Information

I only want events to be fired when the procedure models are actually included in the procedure map, so I've added startPublishing and stopPublishing methods to the ObservableProcedureModel and ObservableParameterModel to signal that. But I also don't /love/ that solution (it just feels clunky).

ObservableParameterModels also need to have a reference to their parent IProcedureModel to be able to properly construct their events, so I've added a setProcedureModel method. But theoretically we could also take the IProcedureModel in as part of the constructor, so that it's guarunteed to be non-null. That would just break the fluent API. I've added a TODO at the relevant place inline to discuss.

@BeksOmega BeksOmega requested a review from a team as a code owner November 4, 2022 22:48
@github-actions github-actions bot added the PR: feature Adds a feature label Nov 4, 2022
@BeksOmega BeksOmega merged commit 0532b5d into google:develop Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants