feat: add firing of procedure events. #6604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run format
andnpm run lint
The details
Resolves
#6516
Proposed Changes
Adds firing procedure events to the procedure data models.
Reason for Changes
Firing events appropriately is good :D
Test Coverage
Enabled all events from #6593
Documentation
N/A
Additional Information
I only want events to be fired when the procedure models are actually included in the procedure map, so I've added
startPublishing
andstopPublishing
methods to theObservableProcedureModel
andObservableParameterModel
to signal that. But I also don't /love/ that solution (it just feels clunky).ObservableParameterModel
s also need to have a reference to their parentIProcedureModel
to be able to properly construct their events, so I've added asetProcedureModel
method. But theoretically we could also take theIProcedureModel
in as part of the constructor, so that it's guarunteed to be non-null. That would just break the fluent API. I've added a TODO at the relevant place inline to discuss.