Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up insertion marker code #6602

Merged
merged 15 commits into from
Nov 10, 2022
Merged

chore: clean up insertion marker code #6602

merged 15 commits into from
Nov 10, 2022

Commits on Nov 3, 2022

  1. chore: move comments

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    eb09ab2 View commit details
    Browse the repository at this point in the history

  2. chore: remove underscores from private property names

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b6bde64 View commit details
    Browse the repository at this point in the history

  3. chore: remove underscores from properties and methods in insertion ma… 

    …rker manager
    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    97eb931 View commit details
    Browse the repository at this point in the history

  4. chore: format

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    2627644 View commit details
    Browse the repository at this point in the history

  5. chore: track closestConnection and localConnection as a single object

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    2ba74ea View commit details
    Browse the repository at this point in the history

  6. chore: format

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    7c12916 View commit details
    Browse the repository at this point in the history

  7. chore: add comments and simplify shouldUpdatePreviews

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    304ee45 View commit details
    Browse the repository at this point in the history

  8. chore(docs): add jsdoc for new params

    @rachel-fenichel
    rachel-fenichel committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b277587 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. chore: use destructuring assignments

    @rachel-fenichel
    rachel-fenichel committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    9ec2af2 View commit details
    Browse the repository at this point in the history

  2. chore: improve readability

    @rachel-fenichel
    rachel-fenichel committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    792b517 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. chore: address review feedback

    @rachel-fenichel
    rachel-fenichel committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    671f886 View commit details
    Browse the repository at this point in the history

  2. chore: respond to review feedback

    @rachel-fenichel
    rachel-fenichel committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    cc6beda View commit details
    Browse the repository at this point in the history

  3. chore: fix types in shouldDelete

    @rachel-fenichel
    rachel-fenichel committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    d896c7f View commit details
    Browse the repository at this point in the history

  4. chore: make wouldDeleteBlock a property

    @rachel-fenichel
    rachel-fenichel committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    028425a View commit details
    Browse the repository at this point in the history

  5. chore: format

    @rachel-fenichel
    rachel-fenichel committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    faebbd5 View commit details
    Browse the repository at this point in the history