Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move Theme to use a Partial type for BlockStyle #6532

Merged
merged 4 commits into from
Oct 11, 2022
Merged

fix: move Theme to use a Partial type for BlockStyle #6532

merged 4 commits into from
Oct 11, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

Fixes #4774

Proposed Changes

Moves the BlockStyle type to have required properties, and use Partial where necessary.

Reason for Changes

Code health

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner October 11, 2022 22:20
@github-actions github-actions bot added the PR: fix Fixes a bug label Oct 11, 2022
@BeksOmega BeksOmega merged commit ca3b9bd into google:develop Oct 11, 2022
@release-please release-please bot mentioned this pull request Oct 11, 2022
Closed
@BeksOmega BeksOmega deleted the fix/block-style-types branch May 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribethb maribethb maribethb approved these changes

Assignees

@maribethb maribethb

Labels
PR: fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlockStyle typings incorrectly mark some properties as required
2 participants
@BeksOmega @maribethb