Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Connections can be highlighted multiple times #6502

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

koenvanwijk
Copy link
Contributor

@koenvanwijk koenvanwijk commented Oct 7, 2022

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

fixes #6501

Proposed Changes

In connection highlight, if highlightPath already exists, then silently return early because it's already highlighted.

Behavior Before Change

image
Calling highlight twice will leave the connection highlight.

Behavior After Change

image
The highlight is not applied twice, so can be removed.

Reason for Changes

Test Coverage

Manually tested, see pictures.

Documentation

No documentation update is needed, now it works as expected and documented.

Additional Information

@koenvanwijk koenvanwijk requested a review from a team as a code owner October 7, 2022 10:11
@google-cla
Copy link

google-cla bot commented Oct 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the PR: fix Fixes a bug label Oct 7, 2022
@rachel-fenichel rachel-fenichel merged commit 581e8ac into google:develop Oct 10, 2022
@rachel-fenichel
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants