chore: work on refactoring gesture code #6401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
fix/any-gesture
branch
from
e6d9062 to
f745304
Compare
rachel-fenichel
approved these changes
Sep 9, 2022
NeilFraser
pushed a commit
that referenced
this pull request
Sep 9, 2022
* chore: work on refactoring gesture code * chore: reorganize throw order * chore: format * chore: PR comments * chore: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Work on #5857
Proposed Changes
Removes
AnyDuringMigrationfrom the gesture code (mostly, I left it in where I think type guards are the correct solution, or where it deals with touch/mouse events being derpy).Removes the different booleans tracking if a dragger exists, and instead just checks if the dagger exists.
Behavior Before Change
Should be no change in behavior.
Behavior After Change
Should be no change in behavior.
Reason for Changes
Types === good?
Test Coverage
Tested dragging things around and clicking things etc. Gestures appear to work, but who really knows.
Documentation
N/A
Additional Information
N/A