chore: Fix or individually disable no-this-alias lint rule violations. #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Aug 22, 2022
| @@ -570,6 +570,7 @@ export class Block implements IASTNodeLocation, IDeletable { | |||
| * @return The block (if any) that surrounds the current block. | |||
| */ | |||
| getSurroundParent(): this|null { | |||
| /* eslint-disable-next-line @typescript-eslint/no-this-alias */ | |||
There was a problem hiding this comment.
it would be sweet if this rule were smart enough to only trigger if the alias was used inside a function. ah well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #5857
Proposed Changes
Fixes or individually disables violations of the no-this-alias lint rule. Where the violation was in the spirit of the rule (shenanigans with
this) I fixed it by generally converting to arrow functions; in cases where the assignment was intentional (generally recursive traversals starting withthis), I disabled the warning.Behavior Before Change
Lint warnings for assigning
thisto a variable were always suppressed.Behavior After Change
Lint warnings for assigning
thisto a variable are selectively suppressed but generally enabled.