refactor: Remove uses of AnyDuringMigration from scrollbar.ts, workspace_svg.ts, contextmenu_registry.ts, and component_manager.ts #6318
Conversation
core/component_manager.ts
Outdated
| componentDataList.forEach(function(ComponentDatum) { | ||
| components.push(ComponentDatum.component); | ||
| components.push(ComponentDatum.component as T); |
There was a problem hiding this comment.
Wouldn't it be better to specify the type of the argument named ComponentDatum? (And maybe give it a less confusing name, since that seems to be the name of a type as well.)
There was a problem hiding this comment.
TS infers the type as ComponentDatum from the typing of componentDataList. If you're referring to the "as T" cast I think we're stuck with that because, while capabilityToComponentIds_ should be giving us only ComponentDatums whose component field is of type T, TS doesn't know that.
There was a problem hiding this comment.
I think I don't fully understand the purpose of the ComponentDatum type here, but the code as revised in this PR looks plausible enough so don't let that stop you submitting it!
| @@ -1212,7 +1141,7 @@ export class WorkspaceSvg extends Workspace implements IASTNodeLocationSvg { | |||
| */ | |||
| translate(x: number, y: number) { | |||
| if (this.useWorkspaceDragSurface_ && this.isDragSurfaceActive_) { | |||
| this.workspaceDragSurface_.translateSurface(x, y); | |||
| this.workspaceDragSurface_?.translateSurface(x, y); | |||
There was a problem hiding this comment.
Why ?. here instead of !.? Was the old code wrong in assuming that .workspaceDragSurface_ can't be undefined here?
cpcallen
added
component: TypeScript
PR: chore
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #5857
Proposed Changes
Removes uses of AnyDuringMigration.