Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to latest Closure compiler and remove our SVG externs #5991

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

gonfunko
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

This PR replaces #5986

Proposed Changes

The newest version of Closure provides its own SVG-related externs, so ours are now redundant and cause errors during compilation. This PR removes our copy of the SVG externs and bumps the Closure compiler version to the latest.

@gonfunko gonfunko requested a review from a team as a code owner March 10, 2022 19:26
@gonfunko gonfunko requested a review from cpcallen March 10, 2022 19:26
@gonfunko gonfunko merged commit 5f822fd into google:develop Mar 10, 2022
@gonfunko gonfunko deleted the closure-svg branch March 10, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants