Renderer requires and requireTypes #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
force-pushed
the
renderer_requires
branch
from
5c16d2a
to
b1aad4d
Compare
rachel-fenichel
force-pushed
the
renderer_requires
branch
from
b1aad4d
to
3c43738
Compare
alschmiedt
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes missing calls to
goog.requireType.Proposed Changes
Add calls to
goog.requireType(and some calls togoog.require) in renderer files.Reason for Changes
Part of enabling the
stricterMissingRequiresclosure compiler flag.Part of cleaning up and making consistent our calls to require and provide, to make it easier to chunk output code correctly.
Test Coverage
Documentation
Additional Information
This change is purely additive. In a later change I will look for unnecessary requires.