Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move logic from startDrag and moveDrag into a utils file #7926

Closed
1 task done
BeksOmega opened this issue Mar 11, 2024 · 2 comments · Fixed by #8566
Closed
1 task done

Move logic from startDrag and moveDrag into a utils file #7926

BeksOmega opened this issue Mar 11, 2024 · 2 comments · Fixed by #8566
Assignees
@johnnesky
Labels
issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days type: cleanup

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

The startDrag and moveDrag methods help you track the state of a drag (e.g. the total delta). Currently they exist on the workspace, and record state on the workspace, even though these methods are only used for resizing comments (block and workspace). E.g. block drags and workspace drags use other methods.

Request

Pull the logic from these methods into a utils file. Unify with other code for recording drags if possible and useful. Have these methods defer to the utils file (since they are public and deleting them is a breaking change).

Alternatives considered

Leave as is because it's not a big deal.

Additional context

No response
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added issue: triage Issues awaiting triage by a Blockly team member labels Mar 11, 2024
@maribethb maribethb added size: small Bugs that can be picked up and completed in 1-3 days type: cleanup and removed issue: triage Issues awaiting triage by a Blockly team member labels Mar 27, 2024
@Apocalypse96
Copy link

Hey @BeksOmega I would love to solve this issue

@BeksOmega
Copy link
Collaborator Author

Go for it @Apocalypse96 This should be merged into develop and it shouldn't include any breaking changes.

Apocalypse96 added a commit to Apocalypse96/blockly that referenced this issue Jul 25, 2024
@Apocalypse96
fix: Move logic from startDrag and moveDrag into a utils file google#…
15c50ce 
…7926
@Apocalypse96 Apocalypse96 mentioned this issue Jul 25, 2024
Closed
1 task
@johnnesky johnnesky mentioned this issue Sep 7, 2024
Merged
1 task
@johnnesky johnnesky self-assigned this Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnnesky johnnesky

Labels
issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days type: cleanup
Projects
None yet
Milestone
No milestone
4 participants
@maribethb @BeksOmega @johnnesky @Apocalypse96