Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blockly.Events.Abstract.fromJson deprecation warning in incorrect location #6830

Closed
1 task done
BeksOmega opened this issue Feb 7, 2023 · 0 comments · Fixed by #6831
Closed
1 task done

Blockly.Events.Abstract.fromJson deprecation warning in incorrect location #6830

BeksOmega opened this issue Feb 7, 2023 · 0 comments · Fixed by #6831
Assignees
@NeilFraser
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@BeksOmega
Copy link
Collaborator

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

The deprecation warning for fromJson in the Abstract event class is in the static method, when it should be in the instance method. It needs to be moved.

Related to #6607
Originally reported: https://groups.google.com/g/blockly/c/uy_8e7Q8XEw/m/8XveAYi3AQAJ

Reproduction steps

No response

Stack trace

No response

Screenshots

No response

Browsers

No response
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Feb 7, 2023
NeilFraser added a commit that referenced this issue Feb 7, 2023
@NeilFraser
fix: move deprecation warning to correct fromJson
d44357e 
Resolves #6830.

https://groups.google.com/g/blockly/c/uy_8e7Q8XEw/m/8XveAYi3AQAJ
@NeilFraser NeilFraser mentioned this issue Feb 7, 2023
Merged
NeilFraser added a commit that referenced this issue Feb 7, 2023
@NeilFraser
fix: move deprecation warning to correct fromJson (#6831)
72b2af2 
Resolves #6830.

https://groups.google.com/g/blockly/c/uy_8e7Q8XEw/m/8XveAYi3AQAJ
@NeilFraser NeilFraser removed the issue: triage Issues awaiting triage by a Blockly team member label Feb 7, 2023
@NeilFraser NeilFraser self-assigned this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NeilFraser NeilFraser

Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move deprecation warning to correct fromJson google/blockly
2 participants
@NeilFraser @BeksOmega