Updated field_dropdown to properly infer its Field type with TS 5.3.3

google · Mar 15, 2024 · 5d8fe68 · 5d8fe68
1 parent 0ecbcde
commit 5d8fe68
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/core/field_dropdown.ts b/core/field_dropdown.ts
@@ -408,6 +408,10 @@ export class FieldDropdown extends Field<string> {
    * @param newValue The input value.
    * @returns A valid language-neutral option, or null if invalid.
    */
+  protected override doClassValidation_(
+    newValue: string,
+  ): string | null | undefined;
+  protected override doClassValidation_(newValue?: string): string | null;
   protected override doClassValidation_(newValue?: string): string | null {
     const options = this.getOptions(true);
     const isValueValid = options.some((option) => option[1] === newValue);

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -100,7 +100,7 @@
     "prettier": "3.2.5",
     "readline-sync": "^1.4.10",
     "rimraf": "^5.0.0",
-    "typescript": "^5.0.2",
+    "typescript": "^5.3.3",
     "webdriverio": "^8.32.2",
     "yargs": "^17.2.1"
   },