fix: zelos full block colour field rendering incorrectly #1932
+2,761
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
2023-q3-eq-release
branch
from
266bd07
to
995a54f
Compare
BeksOmega
force-pushed
the
fix/zelos-colour-field
branch
from
61c5c72
to
546a08f
Compare
BeksOmega
force-pushed
the
2023-q3-eq-release
branch
from
995a54f
to
34dfe96
Compare
BeksOmega
force-pushed
the
2023-q3-eq-release
branch
3 times, most recently
from
53b9476
to
f691307
Compare
BeksOmega
force-pushed
the
fix/zelos-colour-field
branch
from
d9a8a77
to
6694eb7
Compare
|
Pulled in changes from google/blockly#7566 and google/blockly#7584 Retested adding and removing fields in zelos. Tested that selecting th color updates the field, in both modes. |
cpcallen
approved these changes
Nov 3, 2023
BeksOmega
force-pushed
the
fix/zelos-colour-field
branch
from
fab62bf
to
10b4cf9
Compare
BeksOmega
force-pushed
the
fix/zelos-colour-field
branch
from
a6ac004
to
fa0bf80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7442 but for the field in samples
Proposed Changes
See google/blockly#7490
Reason for Changes
See google/blockly#7490
Test Coverage
See google/blockly#7490
Documentation
N/A
Additional Information
N/A