fix(sample-app-ts): Fix #1785 and related problems #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the declaration of the arrow functions passed to addChangeListener have them take Abstract instead of UiBase, since that is how addChangeListener is declared (and there is no facility to receive only UiBase events). Part of google#1785.
The changes made in google#1758 to update generator declarations were not quite correct; in particular, they did not properly account for the need to apply Object.assign only to javascriptGenerator.forBlock, not to all of javascriptGenerator. Not technically part of google#1785, since it the error was not causing _build_ failures, but very much necessary to get the sample apps working again.
Use template literals and apply our usual Prettier style from core.
maribethb
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type declarations for the event listener callbacks passed to
addChangeListener, to have them takeAbstractinstead ofUiBaseevents, since that is howaddChangeListeneris declared (and there is no facility to receive onlyUiBaseevents). Part ofsample-app-tsfails to build #1785.Fix export/import of generator functions for both
sample-appandsample-app-ts.The changes made in fix: update more broken / deprecated APIs for v10 #1758 to update generator declarations were not quite correct; in particular, they did not properly account for the need to apply
Object.assignonly tojavascriptGenerator.forBlock, not to all ofjavascriptGenerator.Not technically part of
sample-app-tsfails to build #1785, since it the error was not causing build failures, but very much necessary to get the sample apps working again.Update formatting of generator to use template literals and apply our usual Prettier style from core.