-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[glTF] Support meshes without indices #474
Labels
Comments
There's evidence that this is partly implemented but incomplete. In GltfLoader::LoadMeshData (scene_gltf_loader.cpp):
However, there's also an independent check for IsNull() very early on when // We require index data so bail if there isn't index data.
if (IsNull(pGltfPrimitive->indices)) {
PPX_ASSERT_MSG(false, "GLTF mesh primitive does not have index data");
return ppx::ERROR_SCENE_INVALID_SOURCE_GEOMETRY_INDEX_DATA;
} Additionally, none of the staging/target buffer sizing code considers the case where |
footballhead
added a commit
to footballhead/bigwheels
that referenced
this issue
Oct 22, 2024
There's an early return with error if `IsNull(pGltfPrimitive->indices)` so genTopology will never be `true`. This can be reverted as part of issue google#474. Until then, it's confusing and creates a burden for refactoring.
apazylbe
pushed a commit
to footballhead/bigwheels
that referenced
this issue
Nov 1, 2024
There's an early return with error if `IsNull(pGltfPrimitive->indices)` so genTopology will never be `true`. This can be reverted as part of issue google#474. Until then, it's confusing and creates a burden for refactoring.
apazylbe
pushed a commit
that referenced
this issue
Nov 1, 2024
There's an early return with error if `IsNull(pGltfPrimitive->indices)` so genTopology will never be `true`. This can be reverted as part of issue #474. Until then, it's confusing and creates a burden for refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
GltfLoader::LoadMeshData
currently complains when a mesh lacksindices
. However, meshes are allowed to not haveindices
. 5.24.2 says:This would allow BigWheels to load and render:
The text was updated successfully, but these errors were encountered: