Explicitly convert depset to list for Bazel compatibility #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag `incompatible_depset_is_not_iterable` will soon be enabled in Bazel by default. Implicitly iteration over a depset will be forbidden.
|
Can you submit an internal CL for this? It makes syncing easier. |
cpovirk
pushed a commit
to cpovirk/bazel-common
that referenced
this pull request
Jun 4, 2019
The flag `incompatible_depset_is_not_iterable` will soon be enabled in Bazel by default. Implicitly iteration over a depset will be forbidden. Closes google#70 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=250879220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag
incompatible_depset_is_not_iterablewill soon beenabled in Bazel by default. Implicitly iteration over a depset
will be forbidden.