Skip to content

Commit

Permalink
Update bazel_common to org.pantsbuild:jarjar:1.7.2
Browse files Browse the repository at this point in the history
This fixes bazel_common's `jarjar_library` which I think was broken when updating to `org.ow2.asm:asm-commons:7.2`.

The issue is that `org.pantsbuild:jarjar:1.6.3` was depending on a class that is removed in the new version of asm-commons:

  java.lang.NoClassDefFoundError: org/objectweb/asm/commons/RemappingClassAdapter

so we need to also update pantsbuild.

I've verified locally that upgrading from 1.6.3 to 1.7.2 fixes the `jarjar_library` for Dagger.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=290281067
  • Loading branch information
bcorso authored and cgdecker committed Jan 17, 2020
1 parent 5bd8dc4 commit 842dd97
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions workspace_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,9 @@ def google_common_workspace_rules():
)

_maven_import(
artifact = "org.pantsbuild:jarjar:1.6.3",
artifact = "org.pantsbuild:jarjar:1.7.2",
licenses = ["notice"],
sha256 = "dbcc085f6db9dc8fc71cb18ff0e6f87ecade1dd9ad3a9b85bdc8da3fef76c018",
sha256 = "0706a455e17b67718abe212e3a77688bbe8260852fc74e3e836d9f2e76d91c27",
)

_maven_import(
Expand Down

0 comments on commit 842dd97

Please sign in to comment.