Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods called <type name><integer> will be interpreted as constructors #995

Open
adetaylor opened this issue Apr 2, 2022 · 0 comments
Open

Methods called <type name><integer> will be interpreted as constructors #995

adetaylor opened this issue Apr 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@adetaylor
Copy link
Collaborator

In fun/mod.rs we look for an integer suffix to the type name, and if it's there, we assume it's a constructor.

We might need more metadata from autocxx-bindgen to do better.
@adetaylor adetaylor added the bug Something isn't working label Apr 2, 2022
@adetaylor adetaylor mentioned this issue Apr 2, 2022
Closed
@adetaylor adetaylor mentioned this issue Sep 11, 2023
Open
adetaylor added a commit that referenced this issue Sep 12, 2023
@adetaylor
Attempts to better rename overloads.
6a02e21 
Work towards #1316 and #995.

For example,
  thingy_autocxx_overload1
This doesn't currently work because ApiVec rejects duplicated APIs at
an earlier stage based upon bindgen function names.
@adetaylor adetaylor mentioned this issue Sep 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adetaylor