Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure string for Py3 compat #271

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Ensure string for Py3 compat #271

merged 1 commit into from
Jun 20, 2019

Conversation

catleeball
Copy link
Contributor

Compatibility casts to binary strings for compatibility. Shoutout to @houglum for these fixes.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 91.608% when pulling 4f63d5d on catleeball:scopefix into 8129b70 on google:master.

@houglum houglum merged commit da8fe1d into google:master Jun 20, 2019
@houglum houglum mentioned this pull request Jun 26, 2019
Closed
@udim udim mentioned this pull request Jul 30, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houglum houglum houglum approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@catleeball @coveralls @houglum @googlebot