Add alternative GPS url coordinate #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubdabasoduba
approved these changes
Nov 14, 2024
MJ1998
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Is https://build.fhir.org/ig/HL7/fhir-extensions/StructureDefinition-geolocation.html the same extension ?
...roid/fhir/datacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
hey @sharon2719 thanks for this. i'm ok with this pr and in the spirit of speeding things up i'll approve this.
BUT can you please add documentation to this page: https://github.com/google/android-fhir/blob/master/docs/use/extensions.md (@FikriMilano has done this very recently). simply add another entry to the bulletpoints.
i'll merge this pr once the documentation is added and tests pass.
...roid/fhir/datacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...roid/fhir/datacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt
Show resolved
Hide resolved
FikriMilano
reviewed
Nov 14, 2024
...roid/fhir/datacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
|
All changes updated cc @jingtang10 |
nsabale7
reviewed
Nov 19, 2024
nsabale7
reviewed
Nov 19, 2024
...roid/fhir/datacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Nitin Sabale <[email protected]>
…atacapture/contrib/views/locationwidget/LocationGpsCoordinateViewHolderFactory.kt Co-authored-by: Nitin Sabale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2713
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.