Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply toSpanned for answer options #2689

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

FikriMilano
Copy link
Collaborator

@FikriMilano FikriMilano commented Oct 7, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2688

Description
Apply to spanned for answer options

Alternative(s) considered
N/A

Type
Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@FikriMilano FikriMilano requested a review from a team as a code owner October 7, 2024 08:13
@FikriMilano FikriMilano requested a review from MJ1998 October 7, 2024 08:13
@FikriMilano FikriMilano changed the title Use toSpanned for answer options Apply toSpanned for answer options Oct 8, 2024
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @nsabale7 said, pls check this functions well in review mode.

otherwise all good - thanks fikri!

@jingtang10 jingtang10 enabled auto-merge (squash) October 14, 2024 18:01
auto-merge was automatically disabled October 14, 2024 22:52

Head branch was pushed to by a user without write access

auto-merge was automatically disabled October 30, 2024 16:33

Head branch was pushed to by a user without write access

@FikriMilano FikriMilano force-pushed the 2688-html-answer-option branch from 1725503 to 7384cea Compare October 30, 2024 16:33
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 4, 2024
FORK
                - With unmerged PR #9
                - WUP  #13

SDK
                - WUP google#2178
                - WUP google#2650
                - WUP google#2663
                - WUP google#2689
ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 5, 2024
    FORK
                    - With unmerged PR #9
                    - WUP  #13

    SDK
                    - WUP google#2178
                    - WUP google#2650
                    - WUP google#2663
                    - WUP google#2689
                    - WUP google#2645
@jingtang10 jingtang10 merged commit e7c8c33 into google:master Nov 5, 2024
6 checks passed
@jingtang10 jingtang10 deleted the 2688-html-answer-option branch November 5, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

HTML support for answer option
4 participants