-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply toSpanned for answer options #2689
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
changed the title
Use toSpanned for answer options
Apply toSpanned for answer options
Oct 8, 2024
jingtang10
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as @nsabale7 said, pls check this functions well in review mode.
otherwise all good - thanks fikri!
...c/main/java/com/google/android/fhir/datacapture/views/factories/DropDownViewHolderFactory.kt
Show resolved
Hide resolved
...va/com/google/android/fhir/datacapture/views/factories/CheckBoxGroupViewHolderFactoryTest.kt
Show resolved
Hide resolved
jingtang10
approved these changes
Oct 14, 2024
auto-merge was automatically disabled
October 14, 2024 22:52
Head branch was pushed to by a user without write access
FikriMilano
force-pushed
the
2688-html-answer-option
branch
from
October 14, 2024 22:56
59af9de
to
c021771
Compare
This reverts commit 8eb6781.
auto-merge was automatically disabled
October 30, 2024 16:33
Head branch was pushed to by a user without write access
FikriMilano
force-pushed
the
2688-html-answer-option
branch
from
October 30, 2024 16:33
1725503
to
7384cea
Compare
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Nov 4, 2024
FORK - With unmerged PR #9 - WUP #13 SDK - WUP google#2178 - WUP google#2650 - WUP google#2663 - WUP google#2689
ndegwamartin
added a commit
to opensrp/android-fhir
that referenced
this pull request
Nov 5, 2024
FORK - With unmerged PR #9 - WUP #13 SDK - WUP google#2178 - WUP google#2650 - WUP google#2663 - WUP google#2689 - WUP google#2645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2688
Description
Apply to spanned for answer options
Alternative(s) considered
N/A
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.