Per question custom style #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FikriMilano
suggested changes
Aug 5, 2024
datacapture/src/main/java/com/google/android/fhir/datacapture/views/HeaderView.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreCustomStyle.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreCustomStyle.kt
Outdated
Show resolved
Hide resolved
santosh-pingle
changed the title
santosh-pingle
requested review from
aditya-07,
jingtang10 and
MJ1998
as code owners
|
jingtang10
reviewed
Aug 7, 2024
FikriMilano
approved these changes
Aug 12, 2024
jingtang10
requested changes
Aug 13, 2024
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreCustomStyle.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreCustomStyle.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreDefaultStyle.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/views/GroupHeaderView.kt
Outdated
Show resolved
Hide resolved
|
jingtang10
reviewed
Aug 14, 2024
...apture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionItemStyle.kt
Show resolved
Hide resolved
|
FikriMilano
approved these changes
Sep 2, 2024
catalog/src/main/assets/component_per_question_custom_style.json
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Sep 3, 2024
...apture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionItemStyle.kt
Show resolved
Hide resolved
aditya-07
reviewed
Sep 3, 2024
ndegwamartin
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 10, 2024
* per question custom style * adding missing file. * update default style. * textAppearance support * rename custom attributes. * github documentation for custom style example. * Address review comments. * address review comment. * update text format icon as component icon. * code cleanup. * Code refactoring and cleanup. * custom style example with multiple question items. * Address review comments. * support prefix per question item custom style * Revert dataconfig changes for custom style mapping. * Address review comments. * Address review comments. * Address review comments. * Address review comments. * Address review comment. --------- Co-authored-by: Santosh Pingle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
Add implementation to customize the style for question item. Allow developers to provide custom style names through the questionnaire JSON file. If a question item with a custom style is reused from the item pool, then apply the default style
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.