Rename install API to index for file in knowledge manager #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
aditya-07,
MJ1998 and
santosh-pingle
as code owners
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
|
@jingtang10 for you consideration, please check out my comment on the Github ticket here. If the recommendations there make sense then this might be an appropriate PR to piggy back the enhancement on. |
FikriMilano
approved these changes
Jul 25, 2024
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
thanks martin - that will be handled in a subsequent pr - let's keep the scope of this pr smaller. |
aditya-07
reviewed
Jul 31, 2024
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Show resolved
Hide resolved
…ledgeManager.kt Co-authored-by: aditya-07 <[email protected]>
…ledgeManager.kt Co-authored-by: aditya-07 <[email protected]>
aditya-07
reviewed
Aug 2, 2024
ndegwamartin
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 10, 2024
* Rename install to index for file * Revert workflow unit tests since they use published knowledge manager * Remove extra dependency in workflow build file * Address review comments * Fix smart immunizations test * Update knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt Co-authored-by: aditya-07 <[email protected]> * Update knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt Co-authored-by: aditya-07 <[email protected]> * Run spotless --------- Co-authored-by: aditya-07 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Rename install API to index for file in knowledge manager
Note In this PR we also change the test dependency in the workflow module to the current version of knowledge manager instead of the published version. This makes sure we're testing against the latest Knowledge Manager APIs.
Alternative(s) considered
NA
Type
Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.