Remove deep copy for answers in question view item. #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santosh-pingle
requested review from
aditya-07,
jingtang10 and
MJ1998
as code owners
santosh-pingle
changed the title
jingtang10
reviewed
Jun 27, 2024
done. |
jingtang10
approved these changes
Jun 27, 2024
santosh-pingle
added a commit
to santosh-pingle/android-fhir
that referenced
this pull request
Jul 8, 2024
* delete operation on updated answers. * Remove deep copy for answers. * unit test. * unit test. * link the issue to added test. --------- Co-authored-by: Santosh Pingle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2593
Description
Earlier, the answers property was initialized by performing a deep copy of the answers from the questionnaire response component. Because of this, when the questionnaire response answers were modified later, the answers property was not synchronized with the modified answers. As a result, the old answers were referred to, which were not synced with the modified answers of the response item.
Now, the issue is fixed by not performing the deep copy operation on the response item answers when the answers property is initialized.
Alternative(s) considered
Other fix was just use
responseItemComponent.answerinstead ofanswersin removeAnswerAt(index) function,Type
Choose one: (Bug fix)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.