Split and limit variables to 999 when using 'IN(...)' #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
requested review from
aditya-07,
jingtang10,
MJ1998 and
santosh-pingle
as code owners
aditya-07
previously requested changes
Jun 19, 2024
engine/src/main/java/com/google/android/fhir/db/impl/dao/LocalChangeDao.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/DatabaseImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/dao/LocalChangeDao.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Jul 22, 2024
engine/src/androidTest/java/com/google/android/fhir/db/impl/DatabaseImplTest.kt
Show resolved
Hide resolved
engine/src/androidTest/java/com/google/android/fhir/db/impl/dao/LocalChangeDaoTest.kt
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/db/impl/dao/LocalChangeDao.kt
Show resolved
Hide resolved
…-in-operator-variables
with 'too many SQL variables in "select .."'
LZRS
force-pushed
the
2559-split-sqlite-in-operator-variables
branch
from
507e7f9 to
51e80a1
Compare
…-in-operator-variables
ndegwamartin
pushed a commit
to opensrp/android-fhir
that referenced
this pull request
Sep 4, 2024
* Split and limit variables to 999 when using 'IN(...)' * Add supporting tests for large variable numbers * Update comments to include github issue with 'too many SQL variables in "select .."'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2559
Description
Chunks the number of variables used in "IN(...)" to 999
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.