-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor syncUpload Method to improve flow and error handling #2173
Conversation
engine/src/main/java/com/google/android/fhir/sync/upload/ResourceConsolidator.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/FhirSynchronizer.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested the demo app with this?
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/impl/FhirEngineImpl.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/Uploader.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/upload/Uploader.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/sync/FhirSynchronizer.kt
Outdated
Show resolved
Hide resolved
@jingtang10 yes, and it worked. I was able to see the upload status update emissions being printed in the logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woohoo!
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
One of the PRs to fix #760
Description
Clear and concise code change description.
Flow<FetchProgress>
Flow<UploadState>
and instead, have the uploader return anUploadSyncResult
, that can be processed by the syncUpload methodCurrent upload:
Proposed upload:
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.