Create the widget for date time question type #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
requested review from
deepankarb,
joiskash,
pankajkatoch and
yigit
as code owners
jingtang10
force-pushed
the
jt/sdc-date-time
branch
from
b87fb22 to
4135af4
Compare
joiskash
suggested changes
Feb 2, 2021
| } | ||
|
|
||
| @Test | ||
| fun shouldSetTextViewText() { |
There was a problem hiding this comment.
Should we rename this test to shouldSetTextInputLayoutHint in all the tests?
| dateInputEditText = itemView.findViewById(R.id.dateInputEditText) | ||
| // Disable direct text input to only allow input from the date picker dialog | ||
| dateInputEditText.keyListener = null | ||
| dateInputEditText.setOnFocusChangeListener { _: View, hasFocus: Boolean -> |
There was a problem hiding this comment.
User experience :
- Open the date widget
- Select date
- Press ok
- Try to open the date widget again. It Does not open
If some one makes a mistake entering the date/time, the have to enter the time/date and then only then are they able to reopen the date widget. Not sure why this is happening.
Also Looks like TextInputLayout remains highlighted if you click on a radio button / check box.
jingtang10
force-pushed
the
jt/sdc-date-time
branch
from
4135af4 to
ebc10b2
Compare
joiskash
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173