Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkFlow Performance: Adds a compiled Library cache that survives multiple executions of the evaluator. #2033

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

vitorpamplona
Copy link
Collaborator

Fixes #[issue number]

Description
Current FhirOperator reloads (and then recompiles) all libraries in every evaluate call, which includes each of the multiple initial expressions in a single questionnaire page. This leads to slow processing of CQL.

This PR adds a basic compiled Library cache that survives multiple executions of the evaluator.

Alternative(s) considered
None

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@vitorpamplona vitorpamplona requested review from a team and santosh-pingle as code owners June 12, 2023 20:33
@vitorpamplona vitorpamplona requested a review from aditya-07 June 12, 2023 20:33
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add more info for the todo (maybe an github issue or a link to a doc)!

@vitorpamplona vitorpamplona merged commit 80ea66f into google:master Jun 19, 2023
@jingtang10 jingtang10 added this to the Workflow Library alpha03 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants