-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a simple NpmManager #2028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktarasenko
commented
Jun 7, 2023
knowledge/src/main/java/com/google/android/fhir/knowledge/ImplementationGuide.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Jul 11, 2023
knowledge/src/main/java/com/google/android/fhir/knowledge/ImplementationGuide.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/npm/CacheManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/npm/NpmPackageManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
@ktarasenko can you resolve the dependency conflict and tag Jing or I when done? We can probably merge this PR! |
- Rename ImplementationGuide.kt to Dependency.kt - Drop the NpmPackageManager.kt
ktarasenko
force-pushed
the
ig-manager-npm
branch
from
August 16, 2023 08:52
0c699bc
to
b518f01
Compare
aditya-07
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments.
...rc/main/java/com/google/android/fhir/knowledge/db/impl/entities/ImplementationGuideEntity.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/Dependency.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/test/java/com/google/android/fhir/knowledge/KnowledgeManagerNpmTest.kt
Outdated
Show resolved
Hide resolved
workflow/src/main/java/com/google/android/fhir/workflow/FhirOperatorBuilder.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Sep 18, 2023
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
knowledge/src/main/java/com/google/android/fhir/knowledge/KnowledgeManager.kt
Outdated
Show resolved
Hide resolved
aditya-07
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jingtang10
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1937
Description
Introduces a simple way to download Implementation Guides and Knowledge Artifacts from the NPM package server.
Alternative(s) considered
I spent some amount of time trying to port the NpmManager from Cqf framework to support android, but the amount of work to make the underlying HAPI machinery was more than the actual implementation of the simple NPM client.
Key difference to Cqf/Hapi solution:
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.