Refactored text overflow in dropdown #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyativyasargus
requested review from
aditya-07,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa and
yigit
as code owners
|
Before After fixes |
|
Thanks @khyativyasargus Looks good to me! |
|
Thanks! @khyativyasargus |
jingtang10
approved these changes
May 3, 2023
ktarasenko
pushed a commit
to ktarasenko/android-fhir
that referenced
this pull request
Jun 29, 2023
* Refactored text overflow in dropdown * Removed unnecessary attributes from drop down list item xml * Update datacapture/src/main/res/layout/drop_down_list_item.xml --------- Co-authored-by: Jing Tang <[email protected]>
ktarasenko
added a commit
that referenced
this pull request
Jun 29, 2023
* Url is not a unique identifier for the library and should be used together with version. Made necessary changes to reflect that * Truncate the input test file to fit the memory. Use the first library with the given url if the version wasn't explicitly provided * Refactored text overflow in dropdown (#1987) * Refactored text overflow in dropdown * Removed unnecessary attributes from drop down list item xml * Update datacapture/src/main/res/layout/drop_down_list_item.xml --------- Co-authored-by: Jing Tang <[email protected]> * Spotless apply --------- Co-authored-by: Omar Ismail <[email protected]> Co-authored-by: khyativyasargus <[email protected]> Co-authored-by: Jing Tang <[email protected]>
omarismail94
added a commit
that referenced
this pull request
Jul 4, 2023
* distinct name for onetime new stuff Fix the version collision in Knowledge Manager (#2043) * Url is not a unique identifier for the library and should be used together with version. Made necessary changes to reflect that * Truncate the input test file to fit the memory. Use the first library with the given url if the version wasn't explicitly provided * Refactored text overflow in dropdown (#1987) * Refactored text overflow in dropdown * Removed unnecessary attributes from drop down list item xml * Update datacapture/src/main/res/layout/drop_down_list_item.xml --------- Co-authored-by: Jing Tang <[email protected]> * Spotless apply --------- Co-authored-by: Omar Ismail <[email protected]> Co-authored-by: khyativyasargus <[email protected]> Co-authored-by: Jing Tang <[email protected]> Support basic HTTP authentication (#2038) * Create a more generic and consistent way of providing authorization header * Update engine/src/main/java/com/google/android/fhir/sync/HttpAuthenticator.kt Co-authored-by: Omar Ismail <[email protected]> * Update doc for HttpAuthenticator --------- Co-authored-by: Omar Ismail <[email protected]> Engine codelab (#2059) * Initial version * make app work * add update function * Run spotless apply * Remove unnecessary header in FHIR Engine codelab README.md --------- Co-authored-by: omarismail <[email protected]> Simplify codelab code (#2060) * Initial version * make app work * add update function * Run spotless apply * Remove unnecessary header in FHIR Engine codelab README.md * Simplify engine codelab code * Update codelabs/engine/app/src/main/java/com/google/android/fhir/codelabs/engine/DownloadWorkManagerImpl.kt Co-authored-by: Omar Ismail <[email protected]> --------- Co-authored-by: omarismail <[email protected]> Co-authored-by: Omar Ismail <[email protected]> Engine codelab (#2061) * Initial version * make app work * add update function * Run spotless apply * Remove unnecessary header in FHIR Engine codelab README.md * Simplify engine codelab code * Update codelabs/engine/app/src/main/java/com/google/android/fhir/codelabs/engine/DownloadWorkManagerImpl.kt Co-authored-by: Omar Ismail <[email protected]> * Update engine codelab * Run spotless --------- Co-authored-by: omarismail <[email protected]> Co-authored-by: Omar Ismail <[email protected]> * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1966
Description
Overflow texts gets cut off in dropdown with current single line textview. When text is multiline , it should overflow to the next line.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Bug Fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.