Cqf expression implementation for dynamic question title #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimoonak
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
maimoonak
force-pushed
the
cqf-expression
branch
from
a82135f to
4c420ca
Compare
maimoonak
force-pushed
the
cqf-expression
branch
from
342635c to
9ab6672
Compare
|
@maimoonak awesome work here! |
FikriMilano
suggested changes
Apr 18, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireViewItem.kt
Outdated
Show resolved
Hide resolved
FikriMilano
reviewed
Apr 18, 2023
There was a problem hiding this comment.
@maimoonak can you also check if the dynamic title works with variable expression?
Try to save the answer to variable expression, then call that variable in cqf expression.
I tried this, it doesn't seem to work, though it works with calculated expression
|
Good catch! Thanks for this. Feedback resolved and PR is ready for review |
|
@shelaghm please take a look at the video @maimoonak attached. |
maimoonak
force-pushed
the
cqf-expression
branch
from
269786b to
85406da
Compare
santosh-pingle
approved these changes
May 3, 2023
There was a problem hiding this comment.
@maimoonak thanks!
Is there a way to add unit test to HeaderViewTest and GroupHeaderViewTest where dynamic text from cqf expression can be shown, or android test to QuestionnaireUiEspressoTest ?
otherwise it looks good to me.
jingtang10
requested changes
May 4, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreExpressions.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/views/GroupHeaderView.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/views/HeaderView.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Jing Tang <[email protected]>
…fhirpath/ExpressionEvaluator.kt Co-authored-by: Jing Tang <[email protected]>
…QuestionnaireViewModel.kt Co-authored-by: Jing Tang <[email protected]>
…views/HeaderView.kt Co-authored-by: Jing Tang <[email protected]>
…views/GroupHeaderView.kt Co-authored-by: Jing Tang <[email protected]>
jingtang10
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1945
Description
Display questionnaire.item.text from FHIRPath expression. In a nutshell, it's like calculated expression which's for answer, but this time for questionnaire.item.text. Advance rendering questionnaireallows the cf-expression on title to display it based on other question`s answers example
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.