Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Optional Encounter ID and Search By URL expansion #1741

Merged
merged 12 commits into from
Dec 5, 2022

Conversation

vitorpamplona
Copy link
Collaborator

@vitorpamplona vitorpamplona commented Dec 1, 2022

Two new features in the PR:

  1. Enables the call to generate a care plan without an encounter.
  2. Restructures FhirDal to support search by URL in any ResourceType (Previously, only Measure and Library were allowed).

The same test case covers both features.

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small addition!

@vitorpamplona vitorpamplona changed the title Workflow Quick Feature: Encounter ID is not required to generate a care plan Workflow Quick Features: Optional Encounter ID and Search By URL expansion Dec 2, 2022
@vitorpamplona vitorpamplona changed the title Workflow Quick Features: Optional Encounter ID and Search By URL expansion Workflow: Optional Encounter ID and Search By URL expansion Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1741 (f7538bd) into master (9a97244) will increase coverage by 42.32%.
The diff coverage is 0.00%.

❗ Current head f7538bd differs from pull request most recent head a4025ab. Consider uploading reports for the commit a4025ab to get more accurate results

@@              Coverage Diff              @@
##             master    #1741       +/-   ##
=============================================
+ Coverage          0   42.32%   +42.32%     
- Complexity        0      384      +384     
=============================================
  Files             0      150      +150     
  Lines             0     5415     +5415     
  Branches          0      972      +972     
=============================================
+ Hits              0     2292     +2292     
- Misses            0     2765     +2765     
- Partials          0      358      +358     
Impacted Files Coverage Δ
.../com/google/android/fhir/workflow/FhirEngineDal.kt 0.00% <0.00%> (ø)
...a/com/google/android/fhir/workflow/FhirOperator.kt 0.00% <0.00%> (ø)
...gle/android/fhir/datacapture/MoreQuestionnaires.kt 0.00% <0.00%> (ø)
...id/fhir/search/filter/TokenParamFilterCriterion.kt 45.45% <0.00%> (ø)
...alidation/PrimitiveTypeAnswerMinLengthValidator.kt 50.00% <0.00%> (ø)
.../QuestionnaireItemAutoCompleteViewHolderFactory.kt 0.00% <0.00%> (ø)
...m/google/android/fhir/sync/remote/FhirConverter.kt 0.00% <0.00%> (ø)
...e/android/fhir/db/impl/entities/DateIndexEntity.kt 100.00% <0.00%> (ø)
.../com/google/android/fhir/sync/remote/HttpLogger.kt 0.00% <0.00%> (ø)
...ogle/android/fhir/sync/remote/RemoteFhirService.kt 0.00% <0.00%> (ø)
... and 142 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change @vitorpamplona !

@omarismail94 omarismail94 enabled auto-merge (squash) December 5, 2022 20:41
@omarismail94
Copy link
Contributor

@vitorpamplona could you merge with master so the PR gets merged?

@omarismail94 omarismail94 merged commit 9b1df44 into google:master Dec 5, 2022
@vitorpamplona vitorpamplona deleted the encounterIdNotRequired branch December 5, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants