-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow: Optional Encounter ID and Search By URL expansion #1741
Workflow: Optional Encounter ID and Search By URL expansion #1741
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small addition!
Codecov Report
@@ Coverage Diff @@
## master #1741 +/- ##
=============================================
+ Coverage 0 42.32% +42.32%
- Complexity 0 384 +384
=============================================
Files 0 150 +150
Lines 0 5415 +5415
Branches 0 972 +972
=============================================
+ Hits 0 2292 +2292
- Misses 0 2765 +2765
- Partials 0 358 +358
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change @vitorpamplona !
@vitorpamplona could you merge with master so the PR gets merged? |
Two new features in the PR:
The same test case covers both features.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #[issue number]
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.