Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fhir data retrieve changes #1624

Closed
wants to merge 3 commits into from
Closed

Conversation

maimoonak
Copy link
Collaborator

@maimoonak maimoonak commented Sep 23, 2022

Fixes issue with Fhir Retrieve to

  • Not skip inactive patients to ensure deceased patients are not omitted unless cql filters it out
  • Handle Task beneficiary which is not sent as contextPath. Rather requestor (Practitioner) is sent as contextPath which is not correct and Task should be filtered on 'for` i.e. subject
  • Handle code filters for entities

Description
Clear and concise code change description.

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@vitorpamplona
Copy link
Collaborator

@maimoonak is this PR still needed?

@jingtang10 jingtang10 assigned ktarasenko and unassigned jingtang10 Apr 24, 2023
@ktarasenko
Copy link
Contributor

The issue with activePatients is fixed in the master.

The remaining two fixes for:

  • Handle Task beneficiary which is not sent as contextPath. Rather requestor (Practitioner) is sent as contextPath which is not correct and Task should be filtered on 'for` i.e. subject
  • Handle code filters for entities
    seem like handling of the edge cases.

I don't have enough context to make a call. Is @maimoonak still around? Are the problems, fixed in this PR common? If no, would it make sense to make an extension to the workflow library to workaround individual integrators issues, or should we rather enforce the standard?

@ktarasenko ktarasenko assigned maimoonak and unassigned ktarasenko Apr 24, 2023
@maimoonak
Copy link
Collaborator Author

This was resolved by @vitorpamplona in PR and discussion #1603 (comment). Issue on DBCG repo is cqframework/clinical_quality_language#858.

@maimoonak maimoonak closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants