-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HAPI structures lib version to 6.0.1 #1616
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1616 +/- ##
=============================================
+ Coverage 0 35.30% +35.30%
- Complexity 0 309 +309
=============================================
Files 0 144 +144
Lines 0 4830 +4830
Branches 0 853 +853
=============================================
+ Hits 0 1705 +1705
- Misses 0 2904 +2904
- Partials 0 221 +221
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@vitorpamplona: I tried to use HAPI6 in this separate PR. Would you please take a look at this PR? Thanks! |
If the goal is to keep the engine+sdc at minSDK 24, I would keep HAPI on 5 just to be sure. The workflow then would require min SDK 26 and replace HAPI 5 with HAPI6 over Java11 when added as a dependency. |
I tested this on Android API level 24. Discussed this with @vitorpamplona. While his PR #1603 does reveal issues with usage of HAPI6, it is caused due to the CQL dependencies exercising code paths not previously used in the engine and sdc libs. For that reason I will go ahead with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work just fine.
https://github.com/google/android-fhir/wiki/External-Dependencies now documents this. |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Update HAPI structures lib version to 6.0.1
Alternative(s) considered
NA
Type
Builds
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.