Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptionExclusive extension support. #1284

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1281

Description

  • Add option exclusive extension support in answerOption.
  • On answer option exclusive click deselects other answer options.
  • On answer option click deselects answer option exclusive.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle santosh-pingle marked this pull request as ready for review April 8, 2022 05:05
@santosh-pingle santosh-pingle enabled auto-merge (squash) April 12, 2022 06:49
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1284 (4315965) into master (e35492b) will decrease coverage by 0.02%.
The diff coverage is 73.07%.

@@             Coverage Diff              @@
##             master    #1284      +/-   ##
============================================
- Coverage     84.19%   84.17%   -0.03%     
  Complexity      678      678              
============================================
  Files           147      147              
  Lines         10711    10735      +24     
  Branches        872      882      +10     
============================================
+ Hits           9018     9036      +18     
- Misses         1232     1233       +1     
- Partials        461      466       +5     
Impacted Files Coverage Δ
...ogle/android/fhir/datacapture/MoreAnswerOptions.kt 69.23% <50.00%> (-16.49%) ⬇️
...QuestionnaireItemCheckBoxGroupViewHolderFactory.kt 72.82% <80.00%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e35492b...4315965. Read the comment docs.

@santosh-pingle santosh-pingle merged commit 08c7d23 into master Apr 12, 2022
@santosh-pingle santosh-pingle deleted the sp/issue-1281-optionExclusive branch April 12, 2022 08:59
ktarasenko pushed a commit that referenced this pull request Apr 12, 2022
* OptionExclusive extension support.

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support optionExclusive extension in questionnaires
2 participants