Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show command buffer vulkan handle for subcommand node. #188

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Show command buffer vulkan handle for subcommand node. #188

merged 2 commits into from
Apr 3, 2020

Conversation

stellama0208
Copy link
Contributor

yalcinmelihyasin
yalcinmelihyasin reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@yalcinmelihyasin yalcinmelihyasin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gapis/api/vulkan/vulkan.go Outdated Show resolved Hide resolved
@stellama0208
Copy link
Contributor Author

The comments above are addressed, feel free to take another look!

@stellama0208 stellama0208 merged commit 6f98dab into google:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisforbes chrisforbes chrisforbes approved these changes

@pmuetschard pmuetschard Awaiting requested review from pmuetschard

@purvisa-at-google-com purvisa-at-google-com Awaiting requested review from purvisa-at-google-com

@yalcinmelihyasin yalcinmelihyasin Awaiting requested review from yalcinmelihyasin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stellama0208 @chrisforbes @yalcinmelihyasin